Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/offline tutorial sample #1608 #1609

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Bugfix/offline tutorial sample #1608 #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1c97d
Fix tracks sorting in Offline tutorial sample code
Oct 8, 2018
693242c
Updated AUTHORS and CONTRIBUTORS
gigon Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Bryan Huh <bhh1988@gmail.com>
Esteban Dosztal <edosztal@gmail.com>
Google Inc. <*@google.com>
Edgeware AB <*@edgeware.tv>
Gil Gonen <gil.gonen@gmail.com>
Giuseppe Samela <giuseppe.samela@gmail.com>
Itay Kinnrot <Itay.Kinnrot@Kaltura.com>
Jason Palmer <jason@jason-palmer.com>
Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Donato Borrello <donato@jwplayer.com>
Duc Pham <duc.pham@edgeware.tv>
Esteban Dosztal <edosztal@gmail.com>
François Beaufort <fbeaufort@google.com>
Gil Gonen <gil.gonen@gmail.com>
Giuseppe Samela <giuseppe.samela@gmail.com>
Itay Kinnrot <itay.kinnrot@kaltura.com>
Jacob Trimble <modmaker@google.com>
Expand Down
8 changes: 4 additions & 4 deletions docs/tutorials/offline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ function selectTracks(tracks) {
// Store the highest bandwidth variant.
var found = tracks
.filter(function(track) { return track.type == 'variant'; })
.sort(function(a, b) { return a.bandwidth > b.bandwidth; })
.sort(function(a, b) { return a.bandwidth - b.bandwidth; })
.pop();
console.log('Offline Track: ' + found);
console.log('Offline Track bandwidth: ' + found.bandwidth);
return [ found ];
}

Expand Down Expand Up @@ -487,9 +487,9 @@ function selectTracks(tracks) {
// Store the highest bandwidth variant.
var found = tracks
.filter(function(track) { return track.type == 'variant'; })
.sort(function(a, b) { return a.bandwidth > b.bandwidth; })
.sort(function(a, b) { return a.bandwidth - b.bandwidth; })
.pop();
console.log('Offline Track: ' + found);
console.log('Offline Track bandwidth: ' + found.bandwidth);
return [ found ];
}

Expand Down