Set server certificate before Store and Delete #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call setServerCertificate before store and delete operations, when serverCertificate exists. In demo application, request and configure certificate when certificateUri is given in asset. Fixes shaka-project#1623.
TheModMaker
suggested changes
Oct 22, 2018
|
Thanks @TheModMaker , I resolved the issues. |
gigon
force-pushed
the
bugfix/offline_1623
branch
from
237c763
to
0e4cd55
Compare
TheModMaker
approved these changes
Oct 24, 2018
|
All tests passed! |
|
Released in v2.5.0-beta2. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library: Call setServerCertificate before store and delete operations, when serverCertificate exists:
In case of store(), it can be configured by the application.
In case of delete(), it is retrieved from the stored manifest.
Demo application: before store(), request and configure the certificate, when a certificateUri is given in asset.
Fixes #1623.