Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getMediaElement function when using src. #1888

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix getMediaElement function when using src. #1888

merged 1 commit into from
Apr 23, 2019

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 23, 2019

Return the mediaElement when using src on player getMediaElement

@avelad avelad changed the title Fix getMediaElement fucntion when using src. Fix getMediaElement function when using src. Apr 23, 2019
joeyparrish
joeyparrish approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 5297282 into shaka-project:master Apr 23, 2019
@avelad avelad deleted the mediaElement branch March 16, 2022 16:00
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @shaka-bot @joeyparrish