Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirPlay support HLS with FairPlay #2257

Merged
merged 3 commits into from
Jan 3, 2020
Merged

AirPlay support HLS with FairPlay #2257

merged 3 commits into from
Jan 3, 2020

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 27, 2019

Resolve #2177

@avelad avelad mentioned this pull request Nov 27, 2019
Closed
@avelad
Copy link
Collaborator Author

avelad commented Dec 12, 2019

I updated the PR to close correctly the open sessions.

The PR is ready for review

@avelad
Copy link
Collaborator Author

avelad commented Dec 30, 2019

I added a new change to only apply the change to videos with webkitCurrentPlaybackTargetIsWireless property

@avelad
Copy link
Collaborator Author

avelad commented Dec 30, 2019

@theodab can you review this PR?

joeyparrish
joeyparrish approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@joeyparrish joeyparrish added the type: enhancement New feature or request label Jan 3, 2020
@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 3e0bb2b into shaka-project:master Jan 3, 2020
@avelad
Copy link
Collaborator Author

avelad commented Jan 4, 2020

@joeyparrish Is it possible to include it in the next 2.5.x?

@joeyparrish
Copy link
Member

I'm not certain, but we can try. It will depend on how bad the merge conflicts are.

@avelad avelad deleted the airplay-fairplay branch January 7, 2020 10:28
joeyparrish pushed a commit that referenced this pull request Jan 15, 2020
@joeyparrish
AirPlay support HLS with FairPlay (#2257)
51f8fe9 
Closes #2177

Change-Id: I681f34d103955055b25f8a0cb6f9fe7030dbd383
@joeyparrish
Copy link
Member

This PR has been cherry-picked for v2.5.8.

@cfra cfra mentioned this pull request Oct 31, 2022
Open
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AirPlay support HLS/FairPlay
3 participants
@avelad @shaka-bot @joeyparrish