Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable setPlaybackStartTime on live streams #231

Merged
merged 2 commits into from Nov 16, 2015

Conversation

baconz
Copy link
Contributor

@baconz baconz commented Nov 13, 2015

It is nice to be able to set the playhead position on in-progress recordings, which use "live" manifests.

Interesting note:

We ran into this because we were setting the starting playback position by changing currentTime directly on the video node. Big, big, big mistake for in progress recordings! If we set the playhead too far into the past before beginPlayback gets called, the liveEdgeOffset gets very large, and users are unable to scrub into the future. It may be worth updating docs so that others don't run into this same trap.

It is nice to be able to set the playhead position on in-progress
recordings, which use "live" manifests.
@joeyparrish joeyparrish added this to the v1.6.0 milestone Nov 13, 2015
@joeyparrish joeyparrish self-assigned this Nov 13, 2015
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 13, 2015
@joeyparrish
Copy link
Member

Hi @baconz,

This is definitely something we should support. Thanks for the pull request.

This may also have helped us identify the cause of #185, which we had not been able to reproduce previously.

We need one thing from you before we can accept this PR. Please read CONTRIBUTING.md for instructions on signing the contributor license agreement and adding yourself to AUTHORS and CONTRIBUTORS.

@baconz
Copy link
Contributor Author

baconz commented Nov 13, 2015

Sweet, thanks, Joey.

I added us into AUTHORS and CONTRIBUTORS. CLA should be forthcoming.

@joeyparrish
Copy link
Member

Thanks, Seth. Just ping me here when the CLA is done.

@baconz
Copy link
Contributor Author

baconz commented Nov 16, 2015

Andrew signed it on Friday. It is associated with the philo-shaka google group, but I'm unable to "manage" it?

Let me know if I need to give this another shot.

@joeyparrish
Copy link
Member

I don't see Philo on our list of corporate CLA signers yet. I'll do some digging internally and see if there is perhaps some kind of queue where new corp CLAs have to be approved by a human.

@baconz
Copy link
Contributor Author

baconz commented Nov 16, 2015

Ok, let me know if I should try initiating again.

@shaka-bot
Copy link
Collaborator

Testing in progress...

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish
Copy link
Member

Turns out I was simply not patient enough. I see your CLA now. Thanks for the contribution!

joeyparrish added a commit that referenced this pull request Nov 16, 2015
enable setPlaybackStartTime on live streams
@joeyparrish joeyparrish merged commit 365cb82 into shaka-project:master Nov 16, 2015
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants