Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bitrate limit #33

Closed

Conversation

sanbornhilland
Copy link
Contributor

This is a proposal for a way to set bandwidth limits on available video tracks as discussed #32.

@joeyparrish
Copy link
Member

I'm not sure about setMaxBandwidth/setMinBandwidth. What about something that would allow the user to set all restriction properties, without having to create setters for each one? Perhaps something like getRestrictions / setRestrictions ?

Also, can you please make this change in the master branch? The 1.2.x branch is for maintenance, to collect bugfixes relative to 1.2.0. New features are being added to master, and will first be released as 1.3.0.

We've already refactored Player in master such that all EME-related stuff is in shaka.media.EmeManager. The way things are organized now, you'll want to provide a reference to the Player's restrictions_ object to EmeManager to set the license-based restrictions.

@sanbornhilland
Copy link
Contributor Author

Yup, I'll submit to master. Was unsure where to go without a develop branch.

I'll put more thought into the setMax/setMin vs get/set restrictions. But this seems like a good point so I'll change it and submit again.

Thanks for the quick feedback.

@joeyparrish
Copy link
Member

Closing, superseded by #36.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants