Fix index out of bound issue when parsing mp4 segment #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
May 13, 2021
|
Thank you for contributing! |
joeyparrish
added
type: bug
joeyparrish
requested changes
May 14, 2021
lib/util/mp4_parser.js
Outdated
| @@ -111,6 +111,12 @@ shaka.util.Mp4Parser = class { | |||
| parseNext(absStart, reader, partialOkay, stopOnPartial) { | |||
| const start = reader.getPosition(); | |||
|
|
|||
| // size(4 bytes) + type(4 bytes) = 8 bytes | |||
| if (stopOnPartial && start + 8 >= reader.getLength()) { | |||
There was a problem hiding this comment.
I think == should be fine, right? If a box had only the required size & name fields, start + 8 == reader.getLength() should be acceptable. Do you agree? Should this become > instead of >=?
Also, it looks like a similar check is needed below, when we handle FULL_BOX types and read versionAndFlags.
There was a problem hiding this comment.
Yes, I agree start + 8 == reader.getLength() should be acceptable.
…rom DataViewReader
joeyparrish
approved these changes
May 17, 2021
|
All tests passed! |
ismena
pushed a commit
that referenced
this pull request
May 17, 2021
1 task
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3402
Screenshots (optional)
Type of change
not work as expected)
Checklist:
./build/all.pyand the build passes./build/test.pyand all tests pass