Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter unsupported H.264 streams in Xbox #3411

Merged
merged 2 commits into from
May 17, 2021

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented May 17, 2021

Close: #3380

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd like to get a second opinion from @michellezhuogg

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 17, 2021
@shaka-bot
Copy link
Collaborator

All tests passed!

@michellezhuogg michellezhuogg merged commit a096bc1 into shaka-project:master May 17, 2021
@avelad avelad deleted the avc1-xbox branch May 18, 2021 05:40
shaka-bot pushed a commit that referenced this pull request Jun 8, 2021
This test case used a configuration that conflicted with PR #3411, in
which we began filtering out H264 over 1080p on Xbox.

Change-Id: If55fa1364639dc4c0fcadd66a3c4af2fcb22264e
joeyparrish pushed a commit that referenced this pull request Jun 16, 2021
Backported to v2.5.x

Change-Id: I2e9b7b3befa9140053fb286c7b881a1506b4f825
joeyparrish added a commit that referenced this pull request Jun 16, 2021
This test case used a configuration that conflicted with PR #3411, in
which we began filtering out H264 over 1080p on Xbox.

Change-Id: If55fa1364639dc4c0fcadd66a3c4af2fcb22264e
joeyparrish pushed a commit that referenced this pull request Jun 16, 2021
Backported to v3.0.x

Change-Id: I9ffdfb79a5b1b86c23acaeb14b7ecdb8bc1258ba
joeyparrish added a commit that referenced this pull request Jun 16, 2021
This test case used a configuration that conflicted with PR #3411, in
which we began filtering out H264 over 1080p on Xbox.

Change-Id: If55fa1364639dc4c0fcadd66a3c4af2fcb22264e
joeyparrish added a commit that referenced this pull request Jun 16, 2021
This test case used a configuration that conflicted with PR #3411, in
which we began filtering out H264 over 1080p on Xbox.

Change-Id: If55fa1364639dc4c0fcadd66a3c4af2fcb22264e
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sintel 4k (multicodec) is not working in Xbox
4 participants