Add align and vertical settings to WebVttGenerator #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
May 17, 2021
test/text/web_vtt_generator_unit.js
Outdated
| 'Test\n\n' + | ||
| '00:00:40.000 --> 00:00:50.000\n' + | ||
| '00:00:40.000 --> 00:00:50.000 align:middle\n' + |
There was a problem hiding this comment.
Could you instead create a separate test case for these?
There was a problem hiding this comment.
The default value is center (https://github.com/google/shaka-player/blob/master/lib/text/cue.js#L83), do you consider that it's necesaary separate the test?
There was a problem hiding this comment.
Sorry. I wasn't referring to align:middle specifically, but all of the settings you've added support for in this PR.
joeyparrish
approved these changes
May 17, 2021
|
All tests passed! |
1 task
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds align and vertical settings to WebVttGenerator