Provide a way to set the stream start time in the manifestparsed event handler #3491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #3434
Added method
Player.setStartTime(startTime: number)
which can be used to update the stream start position in themanifestparsed
event handler based on information obtained from the manifest, such as the position and duration of ad breaks. This is done in a way that avoids unnecessary fetching of segments at the beginning of the stream prior to fetching segments at the desired start position.This change reduces our VOD DAI stream start times from ~4.5 to ~3.5 seconds, which has a measurable effect on our QOS metrics.
Note that I tried to implement this by setting the value of
player.getMediaElement().currentTime
in themanifestparsed
event handler, but that did not work with Safari.Type of change
not work as expected)
Checklist:
./build/all.py
and the build passes./build/test.py
and all tests pass