Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] polyfill webOS vp09 (#3540) #3566

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[fix] polyfill webOS vp09 (#3540) #3566

merged 1 commit into from
Oct 18, 2021

Conversation

david-hm-morgan
Copy link
Contributor

Description

Avoiding faking vp09 as vp9 codec on LG webOS to ensure such streams can still be played.

Fixes #3540

Screenshots (optional)

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@david-hm-morgan david-hm-morgan marked this pull request as ready for review August 5, 2021 14:27
@joeyparrish joeyparrish merged commit 13aafcf into shaka-project:master Oct 18, 2021
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@david-hm-morgan @joeyparrish
fix: Fix vp09 playback on webOS (#3566)
d26a7ef 
Skip the vp09 polyfill for isTypeSupported on this platform.
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@david-hm-morgan @joeyparrish
fix: Fix vp09 playback on webOS (#3566)
a496ddc 
Skip the vp09 polyfill for isTypeSupported on this platform.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in ability to play Angel One stream on LG TV
2 participants
@david-hm-morgan @joeyparrish