Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server Side Ad manager stop #3611

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 31, 2021

This change causes the safe SS-DAI settings to be reset when a stream is unloaded.

@avelad
Copy link
Collaborator Author

avelad commented Sep 10, 2021

@joeyparrish can you review it?

@joeyparrish
Copy link
Member

Were you able to resolve the issue mentioned in the comment?

For SS DAI streams, if a different asset gets unloaded as part of the process of loading a DAI asset, stream manager state gets reset and we don't get any ad events.

Is this not happening any more?

@avelad
Copy link
Collaborator Author

avelad commented Sep 13, 2021

@joeyparrish The problem keeps happening. The problem here is that a part of the code is commented that causes other things to not be released correctly, so I have moved the comment to a lower level (ad_manager vs server_side_ad_manager).

Note: this is a dependency of #3617

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit a17c988 into shaka-project:master Sep 13, 2021
@avelad
Copy link
Collaborator Author

avelad commented Sep 13, 2021

Thanks @joeyparrish !

@avelad avelad deleted the fix-server-side-stop branch September 14, 2021 05:23
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
This change causes the safe SS-DAI settings to be reset when a stream is unloaded.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
This change causes the safe SS-DAI settings to be reset when a stream is unloaded.
joeyparrish pushed a commit that referenced this pull request Oct 12, 2021
This change causes the safe SS-DAI settings to be reset when a stream is unloaded.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants