Add randomUUID polyfill #3669
Merged
Add randomUUID polyfill #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 12:52
joeyparrish
requested changes
Sep 28, 2021
|
|
||
| if (!window.crypto) { | ||
| shaka.log.debug( | ||
| 'window.crypto must be available to install randomUUID polyfill.'); |
There was a problem hiding this comment.
I had to look up support for WebCrypto to realize that it goes back to Chrome 11 / Firefox 26 / IE 11. Can you please add a comment so that some well-meaning person doesn't assume that this is a problem when reading this code in the future?
There was a problem hiding this comment.
A link to https://caniuse.com/cryptography is enough?
joeyparrish
approved these changes
Sep 29, 2021
|
All tests passed! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3662