Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplication of init data to reduce memory usage #3695

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Deduplication of init data to reduce memory usage #3695

merged 1 commit into from
Oct 15, 2021

Conversation

nick-michael
Copy link
Contributor

@nick-michael nick-michael commented Oct 12, 2021 •
edited

Description

Linear streams accumulate init data over time because the init data is pushed to an array regardless of whether or not it already exists as part of the logic to combine periods. This PR will dedupe the init data based on keyId to help reduce memory usage over extended playouts.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit a09d8c9 into shaka-project:master Oct 15, 2021
@theodab
Copy link
Collaborator

theodab commented Oct 15, 2021

Thank you for your contribution!

joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@nick-michael @joeyparrish
fix: Dedupe DRM init data (#3695)
1c0df4b 
Linear streams accumulate init data over time because the init data is pushed to
an array regardless of whether or not it already exists as part of the logic to
combine periods. This PR dedupes the init data based on keyId to help reduce
memory usage over extended playouts.
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@nick-michael @joeyparrish
fix: Dedupe DRM init data (#3695)
4d91de3 
Linear streams accumulate init data over time because the init data is pushed to
an array regardless of whether or not it already exists as part of the logic to
combine periods. This PR dedupes the init data based on keyId to help reduce
memory usage over extended playouts.
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@nick-michael @joeyparrish
fix: Dedupe DRM init data (#3695)
0c7fe7d 
Linear streams accumulate init data over time because the init data is pushed to
an array regardless of whether or not it already exists as part of the logic to
combine periods. This PR dedupes the init data based on keyId to help reduce
memory usage over extended playouts.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nick-michael @shaka-bot @theodab