Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing of HLS 'DEFAULT' attribute #3771

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix parsing of HLS 'DEFAULT' attribute #3771

merged 1 commit into from
Dec 6, 2021

Conversation

pcruiksh
Copy link
Contributor

@pcruiksh pcruiksh commented Nov 24, 2021 •
edited

Description

Correctly obtain value of DEFAULT tag so variants can be tagged as primary, to avoid arbitrary audio language selection in multi-variant playlists.

Fixes #3769

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

@pcruiksh
fix parsing of HLS 'DEFAULT' attribute so variants can correctly be i…
c9327b9 
…dentified as primary, preventing arbitrary language selection in playlists with multiple variants
@pcruiksh pcruiksh force-pushed the bugfix/fixParsingOfHlsDefaultTag branch from 27b37dc to c9327b9 Compare November 24, 2021 15:09
@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit 3e7a5b5 into shaka-project:master Dec 6, 2021
@theodab
Copy link
Collaborator

theodab commented Dec 6, 2021

Good catch. Thanks for the PR!

joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@pcruiksh @joeyparrish
fix(hls): Fixes parsing of HLS 'DEFAULT' attribute (#3771)
7be62fa 
Closes #3769
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@pcruiksh @joeyparrish
fix(hls): Fixes parsing of HLS 'DEFAULT' attribute (#3771)
0eacef4 
Closes #3769
joeyparrish pushed a commit that referenced this pull request Jan 5, 2022
@pcruiksh @joeyparrish
fix(hls): Fixes parsing of HLS 'DEFAULT' attribute (#3771)
06e8e48 
Closes #3769
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary audio not observed for HLS
3 participants
@pcruiksh @shaka-bot @theodab