chore: require node 14 or above #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal sounds good, but can you elaborate on how this helps? |
|
Developers and contributors can easily find minimum required Node version, and easily decide library/dependency versions, also Node features. Now it's not explicit, but most dev dependencies support 12 and above. |
|
Ah, okay. Makes sense. I'll add that info to the commit message when I merge it. |
joeyparrish
approved these changes
May 12, 2022
joeyparrish
pushed a commit
that referenced
this pull request
May 17, 2022
Most of our existing dev dependencies require node 12+, and node 16 is the active LTS for several more months. Let's make node 14 the required minimum for Shaka Player development, to avoid issues with our dev deps failing on older versions.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make it explicit a Node.js version required for development, to make contributions easy.