Attempt to fetch one chunk prior on seeking #429
Conversation
|
I'm not convinced this is ideal or complete but I'd like to see if we can back port this fix to 1.6.x because we will still be relying on 1.6.x for some time and this is causing problems for us. Notably I'm not sure how to properly handle the |
|
The nudge was required on older versions of Chromium. They have since fixed the bug on their end, so we got rid of the nudge in Shaka v2. Let me discuss with the team. It may be cleaner to have you completely remove the nudge in a separate PR first. |
| */ | ||
| shaka.media.SegmentIndex.prototype.findBefore = function(time) { | ||
| var i = shaka.media.SegmentReference.find(this.references, time); | ||
| return i <= 0 ? null : this.references[i - 1]; |
There was a problem hiding this comment.
Please write this conditional in the same style as the one above in find(). That will make it easier to compare.
|
Can you rebase on top of the other PR and resolve conflicts? |
As per issue shaka-project#330, manifests are only required to be approx. correct with respect to their description of the media segments. In order to avoid stalling when seeking through content like this, fetch the chunk prior to the one that supposedly contains the current time. This is an attempt to apply a similar fix to Ia7bb74d0120.
sanbornhilland
force-pushed
the
feature/handleManifestChunkDiscrepancies
branch
from
abe23b3
to
5229e05
Compare
github-actions
bot
added
the
status: archived
As per issue #330, manifests are only required to be approx.
correct with respect to their description of the media segments.
In order to avoid stalling when seeking through content like this,
fetch the chunk prior to the one that supposedly contains the
current time.
This is an attempt to apply a similar fix to Ia7bb74d0120.