Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow add extra features to MediaSource.addSourceBuffer #4527

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 29, 2022

No description provided.

@avelad avelad added the type: enhancement New feature or request label Sep 29, 2022
@avelad avelad added this to the v4.3 milestone Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

Incremental code coverage: 100.00%

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Sep 29, 2022
littlespex
littlespex previously approved these changes Sep 29, 2022
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit on documentation. Looks good otherwise.

externs/shaka/player.js Show resolved Hide resolved
@avelad avelad merged commit 4033be7 into shaka-project:main Sep 30, 2022
@avelad avelad deleted the mediasource-config branch October 3, 2022 17:50
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants