fix: Fix A/V sync in unaligned HLS VOD streams #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
avelad
added
the
priority: P1
joeyparrish
approved these changes
Oct 3, 2022
joeyparrish
changed the title
joeyparrish
changed the title
JulianDomingo
added a commit
that referenced
this pull request
Oct 6, 2022
Fix is based on suggestions from @joeyparrish in #4308 (comment). During automatic adaptations, Shaka will now reset the timestamp offset to ensure the newly active track is properly aligned in the presentation. Verified by disabling ABR and manually triggering variant switches (`shaka.Player.selectVariantTrack()`) between seemingly problematic combinations (e.g., `400k` bps => `6000k` bps stream). Behavior was compared against production. Since `adaptation` events are only triggered by ABR logic (and ABR was disabled for manual testing), `selectVariantTrack()` logic was temporarily changed from: `this.switchVariant_(variant, /* fromAdaptation= */ false, clearBuffer, safeMargin);` => `this.switchVariant_(variant, /* fromAdaptation= */ true, clearBuffer, safeMargin);` to ensure the fixes proposed in this PR were taken into effect and being used during manual testing. Tested content is from the reported bug, located here: #4308 (comment) Closes #4308
JulianDomingo
added a commit
that referenced
this pull request
Oct 6, 2022
Fix is based on suggestions from @joeyparrish in #4308 (comment). During automatic adaptations, Shaka will now reset the timestamp offset to ensure the newly active track is properly aligned in the presentation. Verified by disabling ABR and manually triggering variant switches (`shaka.Player.selectVariantTrack()`) between seemingly problematic combinations (e.g., `400k` bps => `6000k` bps stream). Behavior was compared against production. Since `adaptation` events are only triggered by ABR logic (and ABR was disabled for manual testing), `selectVariantTrack()` logic was temporarily changed from: `this.switchVariant_(variant, /* fromAdaptation= */ false, clearBuffer, safeMargin);` => `this.switchVariant_(variant, /* fromAdaptation= */ true, clearBuffer, safeMargin);` to ensure the fixes proposed in this PR were taken into effect and being used during manual testing. Tested content is from the reported bug, located here: #4308 (comment) Closes #4308
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is based on suggestions from @joeyparrish in #4308 (comment).
During automatic adaptations, Shaka will now reset the timestamp offset to ensure the newly active track is properly aligned in the presentation.
Verified by disabling ABR and manually triggering variant switches (
shaka.Player.selectVariantTrack()) between seemingly problematic combinations (e.g.,400kbps =>6000kbps stream). Behavior was compared against production.Since
adaptationevents are only triggered by ABR logic (and ABR was disabled for manual testing),selectVariantTrack()logic was temporarily changed from:this.switchVariant_(variant, /* fromAdaptation= */ false, clearBuffer, safeMargin);=>
this.switchVariant_(variant, /* fromAdaptation= */ true, clearBuffer, safeMargin);to ensure the fixes proposed in this PR were taken into effect and being used during manual testing. Tested content is from the reported bug, located here: #4308 (comment)
Closes #4308