Convert video.{width,height} from strings to numbers

[hochhaus]

No description provided.

[shaka-bot]

Testing in progress...

[shaka-bot]

Failure:

+ echo START-BUILD
START-BUILD
+ ./build/all.py
157 files checked, no errors found.

   Config loaded: �[36m/var/lib/jenkins/jobs/Manual PR Test/workspace/.htmlhintrc�[39m

   Config loaded: �[36m/var/lib/jenkins/jobs/Manual PR Test/workspace/.htmlhintrc�[39m

   Config loaded: �[36m/var/lib/jenkins/jobs/Manual PR Test/workspace/.htmlhintrc�[39m

�[32mScan 3 files, without errors (34 ms).�[39m
/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/drm_engine_integration.js:55: ERROR - assignment to property width of HTMLVideoElement
found   : number
required: string
    video.width = 600;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/drm_engine_integration.js:56: ERROR - assignment to property height of HTMLVideoElement
found   : number
required: string
    video.height = 400;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/media_source_engine_integration.js:60: ERROR - assignment to property width of HTMLVideoElement
found   : number
required: string
    video.width = 600;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/media_source_engine_integration.js:61: ERROR - assignment to property height of HTMLVideoElement
found   : number
required: string
    video.height = 400;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/streaming_engine_integration.js:75: ERROR - assignment to property width of HTMLVideoElement
found   : number
required: string
    video.width = 600;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/media/streaming_engine_integration.js:76: ERROR - assignment to property height of HTMLVideoElement
found   : number
required: string
    video.height = 400;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/offline/offline_integration.js:28: ERROR - assignment to property width of HTMLVideoElement
found   : number
required: string
    video.width = 600;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/offline/offline_integration.js:29: ERROR - assignment to property height of HTMLVideoElement
found   : number
required: string
    video.height = 400;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/player_integration.js:36: ERROR - assignment to property width of HTMLVideoElement
found   : number
required: string
    video.width = 600;
    ^

/var/lib/jenkins/jobs/Manual PR Test/workspace/test/player_integration.js:37: ERROR - assignment to property height of HTMLVideoElement
found   : number
required: string
    video.height = 400;
    ^

10 error(s), 0 warning(s), 90.4% typed
Build failed
Generating Closure dependencies...
Running Closure linter...
Running htmlhint...
Checking that the build files are complete...
Checking the tests for type errors...
Build step 'Execute shell' marked build as failure

[hochhaus]

It looks like this change depends on the updated compiler. Sorry for the confusion. I didn't realize how recently google/closure-compiler@91014522 was merged.

Would you like me to squash this into #421 or do you just want to merge them at the same time?

[joeyparrish]

No worries. Just make this part of the same PR with the new compiler itself.