Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed LCEVC decode breaking dependencies issue and read me addition #4565

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

vinod-balakrishnan
Copy link
Contributor

Changes are as follows:

  1. Fixed demo breaking dependencies.
  2. Fixed some typos
  3. Added LCEVC support section to readme.

1. Fixed demo breaking dependencies.
2. Fixed some typos
3. Added LCEVC support section to readme
@google-cla
Copy link

google-cla bot commented Oct 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad added this to the v4.3 milestone Oct 11, 2022
@avelad avelad added the type: bug Something isn't working correctly label Oct 11, 2022
@@ -144,6 +144,20 @@ HLS features **not** supported:

[mux.js]: https://github.com/videojs/mux.js/releases

## MPEG-5 Part2 LCEVC Support

**Only supported on browsers with Media Source Extensions SourceBuffer support**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, do you want to support SmartTVs and Consoles in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually yes.

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Oct 11, 2022
@joeyparrish joeyparrish merged commit 3c75d1a into shaka-project:main Oct 11, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants