Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments #4756

Merged
merged 7 commits into from
Dec 1, 2022
Merged

fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments #4756

merged 7 commits into from
Dec 1, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 24, 2022

Fixes #4605

@avelad avelad added this to the v4.4 milestone Nov 24, 2022
@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022 •
edited

Incremental code coverage: 100.00%

@avelad
Merge branch 'main' into cea-608-mp4-encrypted
a652207 
# Conflicts:
#	lib/media/closed_caption_parser.js
joeyparrish
joeyparrish requested changes Nov 30, 2022
View reviewed changes
lib/cea/mp4_cea_parser.js Outdated Show resolved Hide resolved
@joeyparrish
Copy link
Member

@avelad, if you agree to these changes, we can merge. Also, please test with your content to make sure it's working correctly for you. A new test case would be nice, but I don't know how complicated that would be for you and your content.

joeyparrish
joeyparrish previously approved these changes Dec 1, 2022
View reviewed changes
joeyparrish
joeyparrish previously approved these changes Dec 1, 2022
View reviewed changes
@avelad
Copy link
Collaborator Author

avelad commented Dec 1, 2022

I agree with the changes. Thanks!

@avelad avelad merged commit d600109 into shaka-project:main Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Merged
@avelad avelad deleted the cea-608-mp4-encrypted branch December 2, 2022 10:14
joeyparrish added a commit that referenced this pull request Dec 8, 2022
@avelad @joeyparrish
fix(cea): Fix not rendering CEA-608 on encrypted mp4 segments (#4756)
501d4ca 
Fixes #4605

Co-authored-by: Joey Parrish <joeyparrish@google.com>
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Shaka-player not rendering CEA-608 Closed Captions
2 participants
@avelad @joeyparrish