feat: Enable variant failover for BAD_HTTP_STATUS and TIMEOUT #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
type: bug
friday
changed the title
friday
changed the title
|
Sorry @avelad. You beat me to it with the title change :D I'll let you determine if this is a fix or feat. I think it's possibly a behavior change (feat)? |
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Nov 30, 2022
avelad
changed the title
avelad
added
type: enhancement
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables #4189 for two more error types. As mentioned in #4728 404 status results in
BAD_HTTP_STATUSrather thanHTTP_ERROR. I also thinkTIMEOUTshould be included, and another issue was just created for this (#4764), so I included that as well.If we don't want this, then an alternative is to make which errors to handle here configurable, but I thought I'd start with this suggestion.
Closes #4728
Closes #4764