Do not prematurely evict segments from multi-period manifests #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this! This should apply equally to You should also add tests to |
presentationTimeline.getSegmentAvailabilityStart() yields a start time relative to the AST, but all of the reference start/end times are relative to their PTO. We need to normalize the start time to the period before we evict any segments.
|
@joeyparrish I think my last patch addresses all of those issues. Let me know what you think! |
|
Looks good to me. Thanks! |
|
Testing in progress... |
|
All tests passed! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presentationTimeline.getSegmentAvailabilityStart()yields a start time relative to the AST, but all of the reference start/end times are relative to their PTOs. We need to normalize the start time to the period before we evict any segments.