fix: Treat regions uniquely #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure dimensions of regions with the same label are treated appropriately
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Dec 15, 2022
joeyparrish
approved these changes
Dec 15, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
Captions split over stream segment boundaries are repeated over more than one segment. Regions in which they sit maybe described the same but allocated different ids and vice versa. Proposal to treat internal region ids uniqely by encoding the dimensions in the id. fixes #4839
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
Captions split over stream segment boundaries are repeated over more than one segment. Regions in which they sit maybe described the same but allocated different ids and vice versa. Proposal to treat internal region ids uniqely by encoding the dimensions in the id. fixes #4839
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
Captions split over stream segment boundaries are repeated over more than one segment. Regions in which they sit maybe described the same but allocated different ids and vice versa. Proposal to treat internal region ids uniqely by encoding the dimensions in the id. fixes #4839
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
Captions split over stream segment boundaries are repeated over more than one segment. Regions in which they sit maybe described the same but allocated different ids and vice versa. Proposal to treat internal region ids uniqely by encoding the dimensions in the id. fixes #4839
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
Captions split over stream segment boundaries are repeated over more than one segment. Regions in which they sit maybe described the same but allocated different ids and vice versa. Proposal to treat internal region ids uniqely by encoding the dimensions in the id. fixes shaka-project#4839
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captions split over stream segment boundaries are repeated over more than one segment.
Regions in which they sit maybe described the same but allocated different ids and vice versa.
Proposal to treat internal region ids uniqely by encoding the dimensions in the id.
fixes #4839