Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parsing error on Chromecast when resyncing HLS #4869

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

joeyparrish
Copy link
Member

Setting the timestampOffset requires an abort() in some cases on Chromecast.

Issue #4589

Setting the timestampOffset requires an abort() in some cases on Chromecast.
Copy link
Collaborator

@JulianDomingo JulianDomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Incremental code coverage: 100.00%

@joeyparrish joeyparrish merged commit afca6af into shaka-project:main Jan 4, 2023
@joeyparrish joeyparrish deleted the hls-av-sync branch January 4, 2023 19:36
joeyparrish added a commit that referenced this pull request Jan 13, 2023
Setting the timestampOffset requires an abort() in some cases on
Chromecast.

Issue #4589
joeyparrish added a commit that referenced this pull request Jan 13, 2023
Setting the timestampOffset requires an abort() in some cases on
Chromecast.

Issue #4589
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
…t#4869)

Setting the timestampOffset requires an abort() in some cases on
Chromecast.

Issue shaka-project#4589
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants