fix: Fix WebVTT parser failure on REGION blocks #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file. Related to work on PR shaka-project#4767
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
|
@joeyparrish adding support for regions is too complicated? |
avelad
approved these changes
Jan 19, 2023
avelad
added
type: bug
|
I'm sure we can add support for regions, but that's not what I am working on now. I am adding a VTT layout test suite, and the region tests all failed with a parser error, which surprised me. |
|
Incremental code coverage: 100.00% |
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file. Related to work on PR #4767
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file. Related to work on PR #4767
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file. Related to work on PR #4767
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file. Related to work on PR #4767
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not yet support VTT region settings, but we should still not fail when a region block appears in a VTT file.
Related to work on PR #4767