chore: Add text_utils.js #4941
Merged
chore: Add text_utils.js #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: code health
|
Incremental code coverage: 100.00% |
|
Note: This helps prevent this kind of bug ( #4856), preventing duplicate code. |
littlespex
approved these changes
Jan 30, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 30, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 30, 2023
This was referenced Jan 31, 2023
avelad
added a commit
that referenced
this pull request
Feb 3, 2023
Adds color support for SimpleTextDisplayer and WebVttGenerator (only one place to fix both now thanks to #4941). It's limited to the [8 colors classes](https://w3c.github.io/webvtt/#default-text-color) supported by the WebVTT specification, and also works with their 3 or 6-digit hex variants (if the stream has TTML subtitles). It does not support rgb, rgba or any colors other than these 8. Fixes #4545 --------- Co-authored-by: Alvaro Velad Galvan <ladvan91@hotmail.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.