fix: Fire correctly MIN_HDCP_VERSION_NOT_MATCH error #5047
Conversation
avelad
added
type: bug
avelad
added
the
component: EME
|
Incremental code coverage: 0.00% |
| @@ -940,6 +940,9 @@ shaka.media.DrmEngine = class { | |||
| } | |||
| this.destroyer_.ensureNotDestroyed(); | |||
| } catch (e) { | |||
| if (e instanceof shaka.util.Error) { | |||
There was a problem hiding this comment.
Hm.
I spent a little bit looking at this, wondering if it would be better to just move the code that checks status so it happens after the try-catch block. It feels a little weird to produce an error inside the try-catch block, then handle it by just immediately throwing it again.
In the end I think this approach is probably the best, though. I could imagine someone adding some extra function call into the try block in the future, which can also throw a Shaka error, and not noticing the potential problem.
|
I don't understand why it has been merged in Spanish, if the title is in English, sometimes Safari is frustrating :/ |
|
Since the commit was merged into main that way, we need to use the commit override syntax to get it to show up in English in our changelogs. (https://shaka-project.github.io/maintenance/#fixing-release-notes) |
github-actions
bot
added
the
status: archived
BEGIN_COMMIT_OVERRIDE
fix: Fire correctly MIN_HDCP_VERSION_NOT_MATCH error
END_COMMIT_OVERRIDE