fix: prevent bad calls to MediaSource.endOfStream #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Mar 9, 2023
theodab
reviewed
Mar 9, 2023
| // don't call it again. Also do not call if readyState is | ||
| // 'closed' (not attached to video element) since it is not a | ||
| // valid operation. | ||
| if (this.ended() || this.mediaSource_.readyState === 'closed') { |
There was a problem hiding this comment.
Incidentally, the ended method also checks the readyState of MS.
I considered asking you to change that instead of making the change here, but the ended method is used outside of this class so it's probably simpler to keep it as-is.
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This prevents the streaming engine from calling MediaSource.endOfStream when media source's readyState is "closed". It's not valid to close a stream that is already closed. See: https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/endOfStream#exceptions Fixes #5070
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This prevents the streaming engine from calling MediaSource.endOfStream when media source's readyState is "closed". It's not valid to close a stream that is already closed. See: https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/endOfStream#exceptions Fixes #5070
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This prevents the streaming engine from calling MediaSource.endOfStream when media source's readyState is "closed". It's not valid to close a stream that is already closed. See: https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/endOfStream#exceptions Fixes #5070
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This prevents the streaming engine from calling MediaSource.endOfStream when media source's readyState is "closed". It's not valid to close a stream that is already closed. See: https://developer.mozilla.org/en-US/docs/Web/API/MediaSource/endOfStream#exceptions Fixes #5070
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5070
maybe it would make more sense to only call it when the readyState is
'open'?