fix: Fix fetch plugin with old implementations #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
requested review from
joeyparrish,
JulianDomingo,
littlespex and
theodab
|
Incremental code coverage: 75.00% |
martinstark
reviewed
Mar 13, 2023
lib/net/http_fetch_plugin.js
Outdated
Comment on lines
249
to
250
| // eslint-disable-next-line no-restricted-syntax, no-prototype-builtins | ||
| if (!Response.prototype.hasOwnProperty('body')) { |
There was a problem hiding this comment.
would Object.prototype.hasOwnProperty.call(Response.prototype, 'body'); allow removal of the lint exceptions?
Suggested change
| // eslint-disable-next-line no-restricted-syntax, no-prototype-builtins | |
| if (!Response.prototype.hasOwnProperty('body')) { | |
| if (!Object.prototype.hasOwnProperty.call(Response.prototype , 'body')) { |
There was a problem hiding this comment.
You could also just make a Response object, like we do with ReadableStream, right?
if (window.Response) {
const response = new Response('');
if (!response.body) {
return false;
}
} else {
return false;
}There was a problem hiding this comment.
@theodab can you review again?
theodab
approved these changes
Mar 14, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5088