Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2 #5183 #5188

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2 #5183 #5188

merged 1 commit into from
Apr 26, 2023

Conversation

caridley
Copy link
Contributor

@caridley caridley commented Apr 26, 2023 •
edited by joeyparrish

Fixed handling of manifest with new codecs in later periods by adding check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183

@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@joeyparrish joeyparrish merged commit e855326 into shaka-project:main Apr 26, 2023
16 checks passed
@joeyparrish
Copy link
Member

Thank you!

@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 4.3.x that did not occ…
a180b28 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 4.2.x that did not occ…
e26d19e 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Apr 27, 2023
@caridley @joeyparrish
fix: PERIOD_FLATTENING_FAILED error with shaka 3.3.x that did not occ…
2cefcf4 
…ur with shaka 3.1.2 (#5188)

Fixed handling of manifest with new codecs in later periods by adding
check for empty matchedStreams array in createNewOutputStrems()

Fixes #5183
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PERIOD_FLATTENING_FAILED error with shaka 4.3.4 that did not occur with shaka 3.1.2
2 participants
@caridley @joeyparrish