New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DASH): Add MPD Patch support #5247
base: main
Are you sure you want to change the base?
Conversation
Incremental code coverage: 89.52% |
Thank you for contributing! I don't understand the patch adapter, though. I worry that it will not be representative of actual patch streams. I also see it being applied in the demo to a VOD manifest, which should have no need of patching. Patching is only useful for updates to live streams, correct? |
Hi @joeyparrish I agree with you that patch manifest adapter is not ideal, but I wanted to give the ability to test the feature in the demo app as open patch compliant streams are not easy to come by (at least I haven't seen any 😆 ). The reason I chose the ad enabled VOD is because of its behaviour of presenting new segments and periods regularly like a live stream. I can remove remove the manifest adapter if you wish. |
Hi @joeyparrish I have removed the patch adapter. |
Happy to support in this kink of new feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I would be comfortable with an "experimental" flag to enable this, but I want to ensure that the existing flow isn't broken. I'm most concerned about extra calls to combinePeriods
(which can be expensive) and missing calls to set up caption streams.
@tobbee Your URL uses SegmentTimeline, is there any URL that uses SegmentList or SegmentBase? |
Added demo asset, thanks @tobbee. This PR still needs some love though, as initial scope of work is not sufficient to properly play DASH-IF asset. Me and @dave-nicholas will continue work on that. |
@avelad The output is "live" streams and available in three different formats:
I hope you can make these variants work (the first one has very little updates since no Segments are mentioned). Once they work, one can also test with multiperiod variants by adding https://livesim2.dashif.org/livesim2/patch_60/segtimeline_1/periods_60/testpic_2s/Manifest.mpd |
Hi! This PR now supports DASH IF test streams, though there are few gotchas @tobbee
I'm gonna focus on adjusting unit tests now. |
Closes #2228