Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Improve HLS parsing time #5264

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 7, 2023

Related to #5261

This PR delays the creation of the final urls of the segments so that they are not calculated in each media playlist parsing.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Jun 7, 2023
@avelad avelad added this to the v4.4 milestone Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Incremental code coverage: 100.00%

lib/hls/hls_classes.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 8, 2023 09:18
theodab
theodab previously approved these changes Jun 8, 2023
@avelad
Copy link
Collaborator Author

avelad commented Jun 8, 2023

@theodab I added some asserts, can you approve the PR again? Thanks!

Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and another thing just occurred to me too.
This would have probably been better in the last PR, organizationally, but...

Could you add a comment in the JSDoc for shaka.util.ManifestParserUtils.resolveUris that explains that method is slow on SmartTV systems and should be delayed to after loading the manifest if possible? Or whatever the most accurate explanation for this is.
It'd be good to have documentation in the actual codebase, rather than just in GitHub comments.

@avelad
Copy link
Collaborator Author

avelad commented Jun 8, 2023

Oh, and another thing just occurred to me too. This would have probably been better in the last PR, organizationally, but...

Could you add a comment in the JSDoc for shaka.util.ManifestParserUtils.resolveUris that explains that method is slow on SmartTV systems and should be delayed to after loading the manifest if possible? Or whatever the most accurate explanation for this is. It'd be good to have documentation in the actual codebase, rather than just in GitHub comments.

I added the comment

@avelad avelad requested a review from theodab June 8, 2023 09:31
@avelad avelad merged commit 2ca7d0b into shaka-project:main Jun 8, 2023
11 of 15 checks passed
@avelad avelad deleted the hls-parser-improvements branch June 9, 2023 06:56
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants