Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Mark first partial segment as independent always #5312

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix(HLS): Mark first partial segment as independent always #5312

merged 3 commits into from
Jun 20, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 15, 2023

No description provided.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Jun 15, 2023
@avelad avelad added this to the v4.4 milestone Jun 15, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad changed the title feat(HLS): Mark first partial segment as independent always fix(HLS): Mark first partial segment as independent always Jun 15, 2023
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround and removed type: enhancement New feature or request priority: P3 Useful but not urgent labels Jun 15, 2023
joeyparrish
joeyparrish requested changes Jun 16, 2023
View reviewed changes
lib/hls/hls_parser.js Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish June 17, 2023 16:23
@avelad avelad merged commit ea896d5 into shaka-project:main Jun 20, 2023
15 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
Merged
@avelad avelad deleted the partial-independent branch June 20, 2023 19:36
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avelad @joeyparrish