feat(HLS): Optimization of LL-HLS with byterange #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 91.55% |
avelad
force-pushed
the
ll-hls-byterange-optimization
branch
from
e8316c6
to
b43b39f
Compare
|
I've read through, but haven't yet understood the change. I'll need more time. Also, JFYI, Monday is a holiday for Google in the US. |
|
@joeyparrish What this change does is that LL-HLS byterange is processed in the same way that it is done in LL-DASH. With this we achieve more efficiency according to the Akamai paper and what has been tested by me. |
theodab
requested changes
Jun 17, 2023
| if (this.config_.lowLatencyMode && isReadableStreamSupported && isMP4 && | ||
| this.manifest_.type != shaka.media.ManifestParser.HLS) { | ||
| (this.manifest_.type != shaka.media.ManifestParser.HLS || |
There was a problem hiding this comment.
Say, it occurs to me. This assumes that a manifest that isn't HLS is DASH, based on the comment above.
But we now have the constant of shaka.media.ManifestParser.MSS. Is this behavior supported by MSS?
There was a problem hiding this comment.
Yes, this would work for MSS live (in the future)
theodab
approved these changes
Jun 21, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is based on https://www.akamai.com/blog/performance/-using-ll-hls-with-byte-range-addressing-to-achieve-interoperabi