Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix memory leak on SimpleAbrManager #5478

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: Fix memory leak on SimpleAbrManager #5478

merged 1 commit into from
Aug 15, 2023

Conversation

tyrelltle
Copy link
Contributor

@tyrelltle tyrelltle commented Aug 11, 2023 •
edited

closes #5477

Moving this.onNetworkInformationChange_ = null; before creating the navigator.connection event listener.
Currently it resets it to null after creating the listener so the release() wont be able to remove the eventlistener

@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad changed the title fix simple_abr_manager memory leak fix: Fix memory leak on SimpleAbrManager Aug 15, 2023
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Aug 15, 2023
@avelad avelad added this to the v4.4 milestone Aug 15, 2023
@avelad avelad merged commit e8f3ed0 into shaka-project:main Aug 15, 2023
15 of 19 checks passed
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 19, 2023
@tyrelltle @joeyparrish
fix: Fix memory leak on SimpleAbrManager (#5478)
f8cb6ef 
closes
[#5477](#5477)

Moving `this.onNetworkInformationChange_ = null;` before creating the
navigator.connection event listener.
Currently it resets it to null after creating the listener so the
release() wont be able to remove the eventlistener
@github-actions github-actions bot mentioned this pull request Aug 19, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 20, 2023
@tyrelltle @joeyparrish
fix: Fix memory leak on SimpleAbrManager (#5478)
5c352c8 
closes
[#5477](#5477)

Moving `this.onNetworkInformationChange_ = null;` before creating the
navigator.connection event listener.
Currently it resets it to null after creating the listener so the
release() wont be able to remove the eventlistener
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 14, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

SimpleAbrManager event listener memory leak
3 participants
@tyrelltle @avelad @shaka-bot