Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Disable right click on range elements #5497

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(UI): Disable right click on range elements #5497

merged 1 commit into from
Aug 18, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 18, 2023

Fixes #5450

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release labels Aug 18, 2023
@avelad avelad added this to the v4.4 milestone Aug 18, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 50.00%

@avelad avelad merged commit 3333ca4 into shaka-project:main Aug 18, 2023
16 of 18 checks passed
@avelad avelad deleted the ui-right-click-range-elements branch August 18, 2023 12:28
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 19, 2023
@avelad @joeyparrish
fix(UI): Disable right click on range elements (#5497)
1c55e89 
Fixes #5450
@github-actions github-actions bot mentioned this pull request Aug 19, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 20, 2023
@avelad @joeyparrish
fix(UI): Disable right click on range elements (#5497)
c508446 
Fixes #5450
@github-actions github-actions bot mentioned this pull request Aug 20, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 17, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Right clicking on bar causes the video to stop playing with no way to start playing it again.
3 participants
@avelad @theodab @shaka-bot