ci: Fix Chrome tests on Windows in GitHub Actions #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build.
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
alekzz
approved these changes
Aug 28, 2023
|
I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1476634 to let Chrome know they are missing codecs in these builds. |
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
added a commit
that referenced
this pull request
Aug 30, 2023
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build.
joeyparrish
added a commit
that referenced
this pull request
Aug 30, 2023
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build.
echoy-harmonicinc
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build. # Conflicts: # .github/workflows/build-and-test.yaml
echoy-harmonicinc
pushed a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build. # Conflicts: # .github/workflows/build-and-test.yaml
echoy-harmonicinc
added a commit
to harmonicinc-com/shaka-player
that referenced
this pull request
Sep 27, 2023
* ci: Fix Chrome tests on Windows in GitHub Actions (shaka-project#5548) GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests. This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build. # Conflicts: # .github/workflows/build-and-test.yaml * ci: Work around msedgedriver 115+ bug (shaka-project#5618) Specify the explicit path to microsoft-edge on Linux if found, to work around MicrosoftEdge/EdgeWebDriver#102 (comment) This also incorporates shaka-project/webdriver-installer#35, shaka-project/karma-local-wd-launcher#60, and shaka-project/karma-local-wd-launcher#62 to revert earlier workarounds and apply new ones for local test runs. # Conflicts: # build/shaka-lab.yaml # package-lock.json # package.json --------- Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub started installing "Chrome for Testing" builds on Windows and Mac. Unfortunately, these builds don't have support for H264 and AAC codecs, which we need in our tests.
This fixes the issue by explicitly installing an official build of Chrome on Windows, to overwrite the "Chrome for Testing" build.