Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix PES parsing #5559

Merged
merged 3 commits into from
Sep 1, 2023
Merged

fix: Fix PES parsing #5559

merged 3 commits into from
Sep 1, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 30, 2023

This changes the way pes are processed to gain efficiency and avoid parsing incorrect pes.

@avelad avelad marked this pull request as draft August 30, 2023 16:05
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Aug 30, 2023
@avelad avelad added this to the v4.4 milestone Aug 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Incremental code coverage: 90.28%

@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad marked this pull request as ready for review September 1, 2023 08:05
@avelad
Copy link
Collaborator Author

avelad commented Sep 1, 2023

@shaka-bot test ce

@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release and removed priority: P2 Smaller impact or easy workaround labels Sep 1, 2023
@avelad avelad merged commit 5c6ab9e into shaka-project:main Sep 1, 2023
36 of 48 checks passed
@avelad avelad deleted the pes-parsing branch September 1, 2023 09:20
joeyparrish pushed a commit to joeyparrish/shaka-player that referenced this pull request Sep 1, 2023
This changes the way pes are processed to gain efficiency and avoid
parsing incorrect pes.
joeyparrish pushed a commit that referenced this pull request Sep 2, 2023
This changes the way pes are processed to gain efficiency and avoid
parsing incorrect pes.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 31, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants