TTML subtitles: Support for <br> inside a paragraph #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing in progress... |
|
All tests passed! |
ismena
reviewed
Nov 2, 2016
|
No probs. Done! |
|
Testing in progress... |
|
All tests passed! |
|
@birme Did you contribute to the project before? |
|
Yes I have. My name is Jonas Birmé and I believe I am already in the CONTRIBUTORS list |
|
Merged! Thanks for the contribution. |
joeyparrish
pushed a commit
that referenced
this pull request
Nov 30, 2016
Replace <br> inside a paragraph with newlines.
joeyparrish
pushed a commit
that referenced
this pull request
Dec 6, 2016
ismena
pushed a commit
that referenced
this pull request
Dec 15, 2016
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have TTML subtitles that contains
<br>elements inside a paragraph for linebreaking. This pull request replaces the<br>elements with a newline character. Having<br>inside a paragraph is valid in TTML as far as I have understood by looking at the examples in https://www.w3.org/TR/ttaf1-dfxp/