Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Fix manifest update time for LL-DASH #5736

Merged
merged 2 commits into from Oct 11, 2023
Merged

fix(DASH): Fix manifest update time for LL-DASH #5736

merged 2 commits into from Oct 11, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 6, 2023

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Oct 6, 2023
@avelad avelad added this to the v4.6 milestone Oct 6, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 6, 2023 •
edited

Incremental code coverage: 60.53%

joeyparrish
joeyparrish previously requested changes Oct 6, 2023
View reviewed changes
lib/dash/dash_parser.js Outdated Show resolved Hide resolved
@avelad avelad dismissed joeyparrish’s stale review October 11, 2023 09:34

Reviewed by Theodore

@avelad avelad merged commit 8b7141f into shaka-project:main Oct 11, 2023
17 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 11, 2023
Merged
@avelad avelad deleted the ll-dash-manifest-update-time branch October 11, 2023 09:35
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(DASH): Fix manifest update time for LL-DASH (shaka-project#5736)
3ceb55e
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 10, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avelad @shaka-bot @joeyparrish @theodab