Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix DRM workaround for Tizen and Xbox with ac-4 boxes #5812

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 25, 2023

content_workarounds.js was introduced for Tizen and Xbox platforms. We found that that meant a regression where certain streams were unable to be played.

This PR adds ac-4 into the content workarounds in the same was as ec-4 to ensure these streams can be played once more.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround platform: Xbox Issues affecting Xbox platform: Tizen Issues affecting Tizen labels Oct 25, 2023
@avelad avelad added this to the v4.6 milestone Oct 25, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 72a5de3 into shaka-project:main Oct 25, 2023
22 checks passed
@avelad avelad deleted the ac4-content-workarounds branch October 26, 2023 06:16
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
…ject#5812)

`content_workarounds.js` was introduced for Tizen and Xbox platforms. We
found that that meant a regression where certain streams were unable to
be played.

This PR adds ac-4 into the content workarounds in the same was as ec-4
to ensure these streams can be played once more.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Tizen Issues affecting Tizen platform: Xbox Issues affecting Xbox priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants