Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): SegmentTemplate@media not updated after change in manifest #5899

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(DASH): SegmentTemplate@media not updated after change in manifest #5899

merged 1 commit into from
Nov 16, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 16, 2023

Fixes #5898

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Nov 16, 2023
@avelad avelad added this to the v5.0 milestone Nov 16, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 30de177 into shaka-project:main Nov 16, 2023
19 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 16, 2023
Merged
@avelad avelad deleted the dash-media-update branch November 17, 2023 08:53
avelad added a commit that referenced this pull request Nov 22, 2023
@avelad
fix(DASH): SegmentTemplate@media not updated after change in manifest (…
a61538a 
…#5899)

Fixes #5898
@shaka-bot shaka-bot mentioned this pull request Nov 22, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(DASH): SegmentTemplate@media not updated after change in manifest (…
0e41862 
…shaka-project#5899)

Fixes shaka-project#5898
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 15, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

SegmentTemplate@media not updated after change in DASH manifest
3 participants
@avelad @shaka-bot @littlespex