feat: expose CEA708 window position in the cue's region #5924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
CEA708 captions have positioning data available in their windows. However, this isn't currently translated and exposed by shaka though it is parsed from the bitstream. Translates the windows into WebVTT regions and uses the mappings outlined https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-708 This is also partially implements shaka-project#2583.
|
Incremental code coverage: 79.45% |
avelad
added
type: enhancement
theodab
approved these changes
Nov 23, 2023
gkatsev
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Nov 27, 2023
With shaka-project#5924, 708 windows were exposed as Cue regions. Since the region ID was getting set now, the UITextDisplayer was trying to position the regions but it doesn't properly support LINES units. This PR skips positioning the region if the values are in LINES units until that can be properly implemented.
gkatsev
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Nov 27, 2023
With shaka-project#5924, 708 windows were exposed as Cue regions. Since the region ID was getting set now, the UITextDisplayer was trying to position the regions but it doesn't properly support LINES units. This PR skips positioning the region if the values are in LINES units until that can be properly implemented.
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…t#5924) CEA708 captions have positioning data available in their windows. However, this isn't currently translated and exposed by shaka though it is parsed from the bitstream. Translates the windows into WebVTT regions and uses the mappings outlined https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-708 This is also partially implements shaka-project#2583.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEA708 captions have positioning data available in their windows. However, this isn't currently translated and exposed by shaka though it is parsed from the bitstream.
Translates the windows into WebVTT regions and uses the mappings outlined https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-708
This is also partially implements #2583.