Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Correctly display video time and duration for VOD #5929

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 24, 2023

Fixes #5765

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Nov 24, 2023
@avelad avelad added this to the v5.0 milestone Nov 24, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 00ff864 into shaka-project:main Nov 27, 2023
17 of 21 checks passed
@avelad avelad deleted the ui-display-time branch November 27, 2023 08:02
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reported video time is incorrect and video ending never occurs
3 participants