Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore offsets in VTT text tracks #599

Closed
wants to merge 1 commit into from
Closed

Ignore offsets in VTT text tracks #599

wants to merge 1 commit into from

Conversation

sanbornhilland
Copy link
Contributor

Closes #595

@joeyparrish joeyparrish self-assigned this Dec 19, 2016
@joeyparrish
Copy link
Member

This is blocked on discussion in #595. I'm not yet convinced that this is necessary.

@joeyparrish joeyparrish added this to the v2.1.0 milestone Jan 6, 2017
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 6, 2017
@joeyparrish
Copy link
Member

As mentioned in #595 (comment), please change this to add either the offset or the segment time, but not both.

Before we release v2.1, we will remove the flag and always use segment-relative timestamps (and never offsets).

@shaka-bot shaka-bot closed this in 406ca0a Jan 26, 2017
@joeyparrish
Copy link
Member

@sanbornhnewyyz, I went ahead and committed a fix for this myself. Hope you don't mind. Thanks for contributing!

@sanbornhilland
Copy link
Contributor Author

Thanks for the hard work of investigating this. Sorry for letting it slip.

@joeyparrish
Copy link
Member

No worries! We are always happy to help.

joeyparrish added a commit that referenced this pull request Jan 28, 2017
@joeyparrish
Fix doubling of offset for segment-relative cues
3e8847d 
When using segment-relative timestamps in VTT, the presentation
offset has already been factored into the segment time.  Therefore,
it should not be added again in the VTT parser.

Closes #595
Closes #599

Change-Id: I9d062af7a17859f6f3374ecf20369b361f3eac7b
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanbornhilland @joeyparrish