Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(language): make normalize function more readable through destructuring #6094

Merged

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Jan 12, 2024

It was a bit irritating to recall what these split values were during debugging so I decided to name them

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jan 12, 2024
@avelad avelad added this to the v5.0 milestone Jan 12, 2024
@avelad avelad added the type: code health A code health issue label Jan 12, 2024
@avelad
Copy link
Collaborator

avelad commented Jan 12, 2024

Please fix the tests

@vanyaxk vanyaxk force-pushed the chore/make-normalize-function-more-readable branch from c8db0da to e161476 Compare January 12, 2024 11:10
@avelad avelad merged commit 08c2052 into shaka-project:main Jan 12, 2024
11 of 15 checks passed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants