Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text): Add MediaSource.modifyCueCallback #6167

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Jan 26, 2024

This callback gives developers a chance to modify cues after they are parsed but before they are appended.

This callback gives developers a chance to modify cues after they are
parsed but before they are appended.
@theodab theodab added type: enhancement New feature or request component: captions/subtitles The issue involves captions or subtitles labels Jan 26, 2024
@theodab theodab requested a review from avelad January 26, 2024 02:53
@avelad avelad added this to the v5.0 milestone Jan 26, 2024
@theodab theodab merged commit bd944d1 into shaka-project:main Jan 26, 2024
11 of 15 checks passed
@theodab theodab deleted the captionPositionBranch branch January 26, 2024 07:36
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants