Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an option specifying when source buffer removals happen #6242

Merged
merged 1 commit into from Feb 12, 2024
Merged

feat: add an option specifying when source buffer removals happen #6242

merged 1 commit into from Feb 12, 2024

Conversation

JulianDomingo
Copy link
Collaborator

@JulianDomingo JulianDomingo commented Feb 11, 2024 •
edited

Increases the default required removal duration from 0.01 => 1.0.

Closes #6240.

@JulianDomingo JulianDomingo linked an issue Feb 11, 2024 that may be closed by this pull request
Small MediaSource.remove() intervals causing crashes on Cast platforms. #6240
Closed
@JulianDomingo JulianDomingo force-pushed the 6240-small-mediasourceremove-intervals-causing-crashes-on-cast-platforms branch from 6bed023 to 79bcf7b Compare February 12, 2024 07:48
@JulianDomingo JulianDomingo force-pushed the 6240-small-mediasourceremove-intervals-causing-crashes-on-cast-platforms branch from 79bcf7b to 22cb908 Compare February 12, 2024 07:50
@joeyparrish joeyparrish merged commit 93d616e into main Feb 12, 2024
18 of 21 checks passed
@joeyparrish joeyparrish deleted the 6240-small-mediasourceremove-intervals-causing-crashes-on-cast-platforms branch February 12, 2024 18:00
@shaka-bot shaka-bot mentioned this pull request Feb 12, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
@JulianDomingo @joeyparrish
fix: do not remove sub-second amounts from source buffer
267169c 
Partial cherry-pick of #6242

Increases the default required removal duration from `0.01` => `1.0`.

Closes #6240
joeyparrish pushed a commit that referenced this pull request Feb 20, 2024
@JulianDomingo @joeyparrish
fix: do not remove sub-second amounts from source buffer
08c92c5 
Partial cherry-pick of #6242

Increases the default required removal duration from `0.01` => `1.0`.

Closes #6240
joeyparrish pushed a commit that referenced this pull request Feb 20, 2024
@JulianDomingo @joeyparrish
fix: do not remove sub-second amounts from source buffer
4a4c9e9 
Partial cherry-pick of #6242

Increases the default required removal duration from `0.01` => `1.0`.

Closes #6240
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@avelad avelad Awaiting requested review from avelad

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small MediaSource.remove() intervals causing crashes on Cast platforms.
3 participants
@JulianDomingo @joeyparrish @shaka-bot